Skip to content

[WIP] Fix643#645

Closed
PGijsbers wants to merge 7 commits intodevelopfrom
Fix643
Closed

[WIP] Fix643#645
PGijsbers wants to merge 7 commits intodevelopfrom
Fix643

Conversation

@PGijsbers
Copy link
Copy Markdown
Collaborator

Trying to figure out these AppVeyor issues that came with the nbconvert update. Feel free to chime in.

Don't see how it would be a cache issue though...
@PGijsbers PGijsbers changed the base branch from master to develop March 17, 2019 22:20
Editing the script directly on Github :D easy to miss
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 17, 2019

Codecov Report

Merging #645 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #645   +/-   ##
========================================
  Coverage    90.13%   90.13%           
========================================
  Files           32       32           
  Lines         3366     3366           
========================================
  Hits          3034     3034           
  Misses         332      332

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94102f3...e26ff32. Read the comment docs.

@PGijsbers
Copy link
Copy Markdown
Collaborator Author

I am closing this PR as I integrated this fix with PR #644. Reasoning being that the change is minor and this PR currently would litter commit history unnecessarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants